Use WaitGroup.Go for remaining manual Add/Done patterns#4956
Merged
Conversation
These call sites weren't caught by the `use-waitgroup-go` revive rule because they call `Done()` inside separate functions rather than inline. Co-authored-by: Isaac
pietern
force-pushed
the
go1.25-waitgroup-go
branch
from
ce7a67e to
5a066f0
Compare
denik
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wg.Add/wg.Done/gopatterns withwg.Go(...)inlibs/dagrun,libs/filer, andlibs/syncuse-waitgroup-gorevive rule because they callDone()inside separate functions rather than inlineTest plan
go test ./libs/dagrun/ ./libs/filer/ ./libs/sync/passesThis pull request was AI-assisted by Isaac.